energy coding style changes
authorJosh Pelkey <jpelkey@gatech.edu>
Fri, 13 May 2011 14:54:15 -0400
changeset 7174 e97fba349adf
parent 7173 4175a15762d4
child 7175 8fffa1497fba
energy coding style changes
src/energy/model/rv-battery-model.cc
src/energy/model/wifi-radio-energy-model.cc
src/energy/test/basic-energy-model-test.cc
src/energy/test/rv-battery-model-test.cc
--- a/src/energy/model/rv-battery-model.cc	Fri May 13 14:53:52 2011 -0400
+++ b/src/energy/model/rv-battery-model.cc	Fri May 13 14:54:15 2011 -0400
@@ -329,7 +329,7 @@
     {
       // constant load
       calculatedAlpha = m_load[0] * RvModelAFunction (t, t, Seconds(0.0),
-                                                          m_beta);
+                                                      m_beta);
     }
   else
     {
@@ -359,7 +359,7 @@
   for (int m = 1; m <= m_numOfTerms; m++)
     {
       double square = beta * beta * m * m;
-      sum += (exp (- square * (firstDelta)) - exp (- square * (secondDelta))) / square;
+      sum += (exp (-square * (firstDelta)) - exp (-square * (secondDelta))) / square;
     }
   return delta + 2 * sum;
 }
--- a/src/energy/model/wifi-radio-energy-model.cc	Fri May 13 14:53:52 2011 -0400
+++ b/src/energy/model/wifi-radio-energy-model.cc	Fri May 13 14:54:15 2011 -0400
@@ -179,7 +179,7 @@
 
 void
 WifiRadioEnergyModel::SetEnergyDepletionCallback (
-    WifiRadioEnergyDepletionCallback callback)
+  WifiRadioEnergyDepletionCallback callback)
 {
   NS_LOG_FUNCTION (this);
   if (callback.IsNull ())
--- a/src/energy/test/basic-energy-model-test.cc	Fri May 13 14:53:52 2011 -0400
+++ b/src/energy/test/basic-energy-model-test.cc	Fri May 13 14:54:15 2011 -0400
@@ -121,7 +121,7 @@
   NS_TEST_ASSERT_MSG_EQ_RETURNS_BOOL (false, (models.GetN () == 0), "Model list is empty!");
   // get pointer
   Ptr<WifiRadioEnergyModel> devModel =
-      DynamicCast<WifiRadioEnergyModel> (models.Get (0));
+    DynamicCast<WifiRadioEnergyModel> (models.Get (0));
   // check pointer
   NS_TEST_ASSERT_MSG_NE_RETURNS_BOOL (0, devModel, "NULL pointer to device model!");
 
@@ -191,7 +191,7 @@
   NS_LOG_DEBUG ("Difference is " << estRemainingEnergy - remainingEnergy);
   // check remaining energy
   NS_TEST_ASSERT_MSG_EQ_TOL_RETURNS_BOOL (remainingEnergy, estRemainingEnergy, m_tolerance,
-                             "Incorrect remaining energy!");
+                                          "Incorrect remaining energy!");
 
   // obtain radio state
   WifiPhy::State endState = devModel->GetCurrentState ();
--- a/src/energy/test/rv-battery-model-test.cc	Fri May 13 14:53:52 2011 -0400
+++ b/src/energy/test/rv-battery-model-test.cc	Fri May 13 14:54:15 2011 -0400
@@ -780,91 +780,91 @@
   NS_ASSERT (loads.size () == timeStamps.size ());
 
   // create single node
-    NodeContainer c;
-    c.Create (1);
+  NodeContainer c;
+  c.Create (1);
 
-    std::string phyMode ("DsssRate1Mbps");
+  std::string phyMode ("DsssRate1Mbps");
 
-    // disable fragmentation for frames below 2200 bytes
-    Config::SetDefault ("ns3::WifiRemoteStationManager::FragmentationThreshold",
-                        StringValue ("2200"));
-    // turn off RTS/CTS for frames below 2200 bytes
-    Config::SetDefault ("ns3::WifiRemoteStationManager::RtsCtsThreshold",
-                        StringValue ("2200"));
-    // Fix non-unicast data rate to be the same as that of unicast
-    Config::SetDefault ("ns3::WifiRemoteStationManager::NonUnicastMode",
-                        StringValue (phyMode));
+  // disable fragmentation for frames below 2200 bytes
+  Config::SetDefault ("ns3::WifiRemoteStationManager::FragmentationThreshold",
+                      StringValue ("2200"));
+  // turn off RTS/CTS for frames below 2200 bytes
+  Config::SetDefault ("ns3::WifiRemoteStationManager::RtsCtsThreshold",
+                      StringValue ("2200"));
+  // Fix non-unicast data rate to be the same as that of unicast
+  Config::SetDefault ("ns3::WifiRemoteStationManager::NonUnicastMode",
+                      StringValue (phyMode));
 
-    // install YansWifiPhy
-    WifiHelper wifi;
-    wifi.SetStandard (WIFI_PHY_STANDARD_80211b);
+  // install YansWifiPhy
+  WifiHelper wifi;
+  wifi.SetStandard (WIFI_PHY_STANDARD_80211b);
 
-    YansWifiPhyHelper wifiPhy =  YansWifiPhyHelper::Default ();
-    /*
-     * This is one parameter that matters when using FixedRssLossModel, set it to
-     * zero; otherwise, gain will be added.
-     */
-    wifiPhy.Set ("RxGain", DoubleValue (0));
-    // ns-3 supports RadioTap and Prism tracing extensions for 802.11b
-    wifiPhy.SetPcapDataLinkType (YansWifiPhyHelper::DLT_IEEE802_11_RADIO);
+  YansWifiPhyHelper wifiPhy =  YansWifiPhyHelper::Default ();
+  /*
+   * This is one parameter that matters when using FixedRssLossModel, set it to
+   * zero; otherwise, gain will be added.
+   */
+  wifiPhy.Set ("RxGain", DoubleValue (0));
+  // ns-3 supports RadioTap and Prism tracing extensions for 802.11b
+  wifiPhy.SetPcapDataLinkType (YansWifiPhyHelper::DLT_IEEE802_11_RADIO);
 
-    YansWifiChannelHelper wifiChannel ;
-    wifiChannel.SetPropagationDelay ("ns3::ConstantSpeedPropagationDelayModel");
-    wifiPhy.SetChannel (wifiChannel.Create ());
+  YansWifiChannelHelper wifiChannel ;
+  wifiChannel.SetPropagationDelay ("ns3::ConstantSpeedPropagationDelayModel");
+  wifiPhy.SetChannel (wifiChannel.Create ());
 
-    // Add a non-QoS upper MAC, and disable rate control
-    NqosWifiMacHelper wifiMac = NqosWifiMacHelper::Default ();
-    wifi.SetRemoteStationManager ("ns3::ConstantRateWifiManager",
-                                  "DataMode", StringValue(phyMode),
-                                  "ControlMode", StringValue(phyMode));
-    // Set it to ad-hoc mode
-    wifiMac.SetType ("ns3::AdhocWifiMac");
-    NetDeviceContainer devices = wifi.Install (wifiPhy, wifiMac, c);
+  // Add a non-QoS upper MAC, and disable rate control
+  NqosWifiMacHelper wifiMac = NqosWifiMacHelper::Default ();
+  wifi.SetRemoteStationManager ("ns3::ConstantRateWifiManager",
+                                "DataMode", StringValue(phyMode),
+                                "ControlMode", StringValue(phyMode));
+  // Set it to ad-hoc mode
+  wifiMac.SetType ("ns3::AdhocWifiMac");
+  NetDeviceContainer devices = wifi.Install (wifiPhy, wifiMac, c);
 
-    // Create and install battery model and device models
-    // RV battery model
-    RvBatteryModelHelper rvModelHelper;
-    // Set alpha & beta values
-    rvModelHelper.Set ("RvBatteryModelAlphaValue", DoubleValue (m_alpha));
-    rvModelHelper.Set ("RvBatteryModelBetaValue", DoubleValue (m_beta));
-    // install source
-    EnergySourceContainer sources = rvModelHelper.Install (c);
-    // device energy model
-    WifiRadioEnergyModelHelper radioEnergyHelper;
-    // set VariableLoadTestIDLE current, which will be the constant load
-    radioEnergyHelper.Set ("IdleCurrentA", DoubleValue (loads[0]));
-    // install on node
-    DeviceEnergyModelContainer deviceModels = radioEnergyHelper.Install (devices, sources);
+  // Create and install battery model and device models
+  // RV battery model
+  RvBatteryModelHelper rvModelHelper;
+  // Set alpha & beta values
+  rvModelHelper.Set ("RvBatteryModelAlphaValue", DoubleValue (m_alpha));
+  rvModelHelper.Set ("RvBatteryModelBetaValue", DoubleValue (m_beta));
+  // install source
+  EnergySourceContainer sources = rvModelHelper.Install (c);
+  // device energy model
+  WifiRadioEnergyModelHelper radioEnergyHelper;
+  // set VariableLoadTestIDLE current, which will be the constant load
+  radioEnergyHelper.Set ("IdleCurrentA", DoubleValue (loads[0]));
+  // install on node
+  DeviceEnergyModelContainer deviceModels = radioEnergyHelper.Install (devices, sources);
 
 
-    Ptr<WifiRadioEnergyModel> wifiDevicePtr = DynamicCast<WifiRadioEnergyModel> (deviceModels.Get (0));
-    // schedule load change events
-    for (uint32_t i = 1; i < loads.size (); i++)
-      {
-        Simulator::Schedule (timeStamps[i], &WifiRadioEnergyModel::SetIdleCurrentA,
-                             wifiDevicePtr, loads[i]);
-      }
+  Ptr<WifiRadioEnergyModel> wifiDevicePtr = DynamicCast<WifiRadioEnergyModel> (deviceModels.Get (0));
+  // schedule load change events
+  for (uint32_t i = 1; i < loads.size (); i++)
+    {
+      Simulator::Schedule (timeStamps[i], &WifiRadioEnergyModel::SetIdleCurrentA,
+                           wifiDevicePtr, loads[i]);
+    }
 
-    // run simulation
-    Simulator::Stop (Seconds (70000.0));
-    Simulator::Run ();
+  // run simulation
+  Simulator::Stop (Seconds (70000.0));
+  Simulator::Run ();
 
-    Time actualLifetime;
-    Ptr<RvBatteryModel> srcPtr = DynamicCast<RvBatteryModel> (sources.Get (0));
-    actualLifetime = srcPtr->GetLifetime ();
+  Time actualLifetime;
+  Ptr<RvBatteryModel> srcPtr = DynamicCast<RvBatteryModel> (sources.Get (0));
+  actualLifetime = srcPtr->GetLifetime ();
 
-    NS_LOG_DEBUG ("Expected lifetime = " << expLifetime.GetSeconds () << "s");
-    NS_LOG_DEBUG ("Actual lifetime = " << actualLifetime.GetSeconds () << "s");
-    NS_LOG_DEBUG ("Difference = " << expLifetime.GetSeconds () - actualLifetime.GetSeconds () << "s");
+  NS_LOG_DEBUG ("Expected lifetime = " << expLifetime.GetSeconds () << "s");
+  NS_LOG_DEBUG ("Actual lifetime = " << actualLifetime.GetSeconds () << "s");
+  NS_LOG_DEBUG ("Difference = " << expLifetime.GetSeconds () - actualLifetime.GetSeconds () << "s");
 
-    //NS_TEST_ASSERT_MSG_EQ_RETURNS_BOOL (actualLifetime, expLifetime, "Incorrect lifetime!");
-    NS_TEST_ASSERT_MSG_EQ_TOL_RETURNS_BOOL (actualLifetime.GetSeconds (), expLifetime.GetSeconds (),
-                               120, // error tolerance = 120s
-                               "Incorrect lifetime!");
+  //NS_TEST_ASSERT_MSG_EQ_RETURNS_BOOL (actualLifetime, expLifetime, "Incorrect lifetime!");
+  NS_TEST_ASSERT_MSG_EQ_TOL_RETURNS_BOOL (actualLifetime.GetSeconds (), expLifetime.GetSeconds (),
+                                          120, // error tolerance = 120s
+                                          "Incorrect lifetime!");
 
-    Simulator::Destroy ();
+  Simulator::Destroy ();
 
-    return false; // error free
+  return false;   // error free
 }
 
 // -------------------------------------------------------------------------- //