Revert [Coverity] Logically dead code (DEADCODE)
NS_ASSERT vanishes in optimized builds, so return code check still needed.
--- a/src/network/model/nix-vector.cc Mon Jul 01 09:59:24 2013 -0700
+++ b/src/network/model/nix-vector.cc Mon Jul 01 10:08:20 2013 -0700
@@ -311,8 +311,7 @@
// return zero if an entire nix-vector was
// not deserialized
- // This check is obviated by prior assert
- return 1;
+ return (sizeCheck != 0) ? 0 : 1;
}
void
--- a/src/network/model/packet-metadata.cc Mon Jul 01 09:59:24 2013 -0700
+++ b/src/network/model/packet-metadata.cc Mon Jul 01 10:08:20 2013 -0700
@@ -1349,9 +1349,7 @@
UpdateTail (tmp);
}
NS_ASSERT (desSize == 0);
- // Return zero if entire meta data was not deserialized
- // This check is obviated by prior assert
- return 1;
+ return (desSize !=0) ? 0 : 1;
}
uint8_t*