# HG changeset patch # User Mathieu Lacage # Date 1181213517 -7200 # Node ID 4d2da35c09b0c7e4c560bfd32400670a8068c08a # Parent 777fcfabc1c8040d0e40893b83b6546f412c9a4b PacketHistory -> PacketMetadata diff -r 777fcfabc1c8 -r 4d2da35c09b0 src/common/packet-metadata.cc --- a/src/common/packet-metadata.cc Thu Jun 07 12:48:52 2007 +0200 +++ b/src/common/packet-metadata.cc Thu Jun 07 12:51:57 2007 +0200 @@ -27,38 +27,38 @@ #include "chunk.h" #include "buffer.h" -NS_DEBUG_COMPONENT_DEFINE ("PacketHistory"); +NS_DEBUG_COMPONENT_DEFINE ("PacketMetadata"); namespace ns3 { -bool PacketHistory::m_enable = false; -uint32_t PacketHistory::m_maxSize = 0; -uint16_t PacketHistory::m_chunkUid = 0; -PacketHistory::DataFreeList PacketHistory::m_freeList; +bool PacketMetadata::m_enable = false; +uint32_t PacketMetadata::m_maxSize = 0; +uint16_t PacketMetadata::m_chunkUid = 0; +PacketMetadata::DataFreeList PacketMetadata::m_freeList; bool g_optOne = false; void -PacketHistory::Enable (void) +PacketMetadata::Enable (void) { m_enable = true; } void -PacketHistory::SetOptOne (bool optOne) +PacketMetadata::SetOptOne (bool optOne) { g_optOne = optOne; } void -PacketHistory::ReserveCopy (uint32_t size) +PacketMetadata::ReserveCopy (uint32_t size) { - struct PacketHistory::Data *newData = PacketHistory::Create (m_used + size); + struct PacketMetadata::Data *newData = PacketMetadata::Create (m_used + size); memcpy (newData->m_data, m_data->m_data, m_used); newData->m_dirtyEnd = m_used; m_data->m_count--; if (m_data->m_count == 0) { - PacketHistory::Recycle (m_data); + PacketMetadata::Recycle (m_data); } m_data = newData; if (m_head != 0xffff) @@ -74,7 +74,7 @@ } } void -PacketHistory::Reserve (uint32_t size) +PacketMetadata::Reserve (uint32_t size) { NS_ASSERT (m_data != 0); if (m_data->m_size >= m_used + size && @@ -92,7 +92,7 @@ } uint32_t -PacketHistory::GetUleb128Size (uint32_t value) const +PacketMetadata::GetUleb128Size (uint32_t value) const { if (value < 0x80) { @@ -113,7 +113,7 @@ return 5; } uint32_t -PacketHistory::ReadUleb128 (const uint8_t **pBuffer) const +PacketMetadata::ReadUleb128 (const uint8_t **pBuffer) const { const uint8_t *buffer = *pBuffer; uint32_t result = 0; @@ -162,14 +162,14 @@ } void -PacketHistory::Append16 (uint16_t value, uint8_t *buffer) +PacketMetadata::Append16 (uint16_t value, uint8_t *buffer) { buffer[0] = value & 0xff; value >>= 8; buffer[1] = value; } bool -PacketHistory::TryToAppendFast (uint32_t value, uint8_t **pBuffer, uint8_t *end) +PacketMetadata::TryToAppendFast (uint32_t value, uint8_t **pBuffer, uint8_t *end) { uint8_t *start = *pBuffer; if (value < 0x80 && start < end) @@ -190,7 +190,7 @@ return false; } bool -PacketHistory::TryToAppend16 (uint16_t value, uint8_t **pBuffer, uint8_t *end) +PacketMetadata::TryToAppend16 (uint16_t value, uint8_t **pBuffer, uint8_t *end) { uint8_t *start = *pBuffer; if (start + 1 < end) @@ -203,7 +203,7 @@ return false; } bool -PacketHistory::TryToAppend32 (uint32_t value, uint8_t **pBuffer, uint8_t *end) +PacketMetadata::TryToAppend32 (uint32_t value, uint8_t **pBuffer, uint8_t *end) { uint8_t *start = *pBuffer; if (start + 3 < end) @@ -218,7 +218,7 @@ return false; } bool -PacketHistory::TryToAppend (uint32_t value, uint8_t **pBuffer, uint8_t *end) +PacketMetadata::TryToAppend (uint32_t value, uint8_t **pBuffer, uint8_t *end) { uint8_t *start = *pBuffer; if (value < 0x80 && start < end) @@ -286,7 +286,7 @@ } void -PacketHistory::AppendValueExtra (uint32_t value, uint8_t *buffer) +PacketMetadata::AppendValueExtra (uint32_t value, uint8_t *buffer) { if (value < 0x200000) { @@ -332,7 +332,7 @@ } void -PacketHistory::AppendValue (uint32_t value, uint8_t *buffer) +PacketMetadata::AppendValue (uint32_t value, uint8_t *buffer) { if (value < 0x80) { @@ -351,7 +351,7 @@ } void -PacketHistory::UpdateTail (uint16_t written) +PacketMetadata::UpdateTail (uint16_t written) { if (m_head == 0xffff) { @@ -376,7 +376,7 @@ void -PacketHistory::UpdateHead (uint16_t written) +PacketMetadata::UpdateHead (uint16_t written) { if (m_head == 0xffff) { @@ -400,7 +400,7 @@ } uint16_t -PacketHistory::AddSmall (const struct PacketHistory::SmallItem *item) +PacketMetadata::AddSmall (const struct PacketMetadata::SmallItem *item) { NS_ASSERT (m_data != 0); if (g_optOne) @@ -464,9 +464,9 @@ } uint16_t -PacketHistory::AddBig (uint32_t next, uint32_t prev, - const PacketHistory::SmallItem *item, - const PacketHistory::ExtraItem *extraItem) +PacketMetadata::AddBig (uint32_t next, uint32_t prev, + const PacketMetadata::SmallItem *item, + const PacketMetadata::ExtraItem *extraItem) { NS_ASSERT (m_data != 0); uint32_t typeUid = ((item->typeUid & 0x1) == 0x1)?item->typeUid:item->typeUid+1; @@ -509,8 +509,8 @@ } void -PacketHistory::ReplaceTail (PacketHistory::SmallItem *item, - PacketHistory::ExtraItem *extraItem, +PacketMetadata::ReplaceTail (PacketMetadata::SmallItem *item, + PacketMetadata::ExtraItem *extraItem, uint32_t available) { NS_ASSERT (m_data != 0); @@ -538,12 +538,12 @@ } // create a copy of the packet. - PacketHistory h (m_packetUid, 0); + PacketMetadata h (m_packetUid, 0); uint16_t current = m_head; while (current != 0xffff && current != m_tail) { - struct PacketHistory::SmallItem tmpItem; - PacketHistory::ExtraItem tmpExtraItem; + struct PacketMetadata::SmallItem tmpItem; + PacketMetadata::ExtraItem tmpExtraItem; ReadItems (current, &tmpItem, &tmpExtraItem); uint16_t written = h.AddBig (0xffff, h.m_tail, &tmpItem, &tmpExtraItem); @@ -557,9 +557,9 @@ } uint32_t -PacketHistory::ReadItems (uint16_t current, - struct PacketHistory::SmallItem *item, - struct PacketHistory::ExtraItem *extraItem) const +PacketMetadata::ReadItems (uint16_t current, + struct PacketMetadata::SmallItem *item, + struct PacketMetadata::ExtraItem *extraItem) const { const uint8_t *buffer = &m_data->m_data[current]; item->next = buffer[0]; @@ -594,8 +594,8 @@ return buffer - &m_data->m_data[current]; } -struct PacketHistory::Data * -PacketHistory::Create (uint32_t size) +struct PacketMetadata::Data * +PacketMetadata::Create (uint32_t size) { NS_DEBUG ("create size="< void -PacketHistoryTest::RegisterHeader (void) +PacketMetadataTest::RegisterHeader (void) { static bool registered = false; if (!registered) { - m_printer.AddHeaderPrinter (MakeCallback (&PacketHistoryTest::PrintHeader, this), - MakeCallback (&PacketHistoryTest::PrintFragment, this)); + m_printer.AddHeaderPrinter (MakeCallback (&PacketMetadataTest::PrintHeader, this), + MakeCallback (&PacketMetadataTest::PrintFragment, this)); registered = true; } } template void -PacketHistoryTest::RegisterTrailer (void) +PacketMetadataTest::RegisterTrailer (void) { static bool registered = false; if (!registered) { - m_printer.AddTrailerPrinter (MakeCallback (&PacketHistoryTest::PrintTrailer, this), - MakeCallback (&PacketHistoryTest::PrintFragment, this)); + m_printer.AddTrailerPrinter (MakeCallback (&PacketMetadataTest::PrintTrailer, this), + MakeCallback (&PacketMetadataTest::PrintFragment, this)); registered = true; } } @@ -1275,7 +1275,7 @@ template void -PacketHistoryTest::PrintHeader (std::ostream &os, uint32_t packetUid, uint32_t size, +PacketMetadataTest::PrintHeader (std::ostream &os, uint32_t packetUid, uint32_t size, const HistoryHeader *header) { if (!header->IsOk ()) @@ -1287,7 +1287,7 @@ template void -PacketHistoryTest::PrintTrailer (std::ostream &os, uint32_t packetUid, uint32_t size, +PacketMetadataTest::PrintTrailer (std::ostream &os, uint32_t packetUid, uint32_t size, const HistoryTrailer *trailer) { if (!trailer->IsOk ()) @@ -1297,21 +1297,21 @@ m_prints.push_back (N); } void -PacketHistoryTest::PrintFragment (std::ostream &os,uint32_t packetUid, +PacketMetadataTest::PrintFragment (std::ostream &os,uint32_t packetUid, uint32_t size,std::string & name, struct PacketPrinter::FragmentInformation info) { m_prints.push_back (info.end - info.start); } void -PacketHistoryTest::PrintDefault (std::ostream& os,uint32_t packetUid, +PacketMetadataTest::PrintDefault (std::ostream& os,uint32_t packetUid, uint32_t size,std::string& name, struct PacketPrinter::FragmentInformation info) { NS_ASSERT (false); } void -PacketHistoryTest::PrintPayload (std::ostream &os,uint32_t packetUid, +PacketMetadataTest::PrintPayload (std::ostream &os,uint32_t packetUid, uint32_t size, struct PacketPrinter::FragmentInformation info) { @@ -1320,13 +1320,13 @@ void -PacketHistoryTest::CleanupPrints (void) +PacketMetadataTest::CleanupPrints (void) { m_prints.clear (); } bool -PacketHistoryTest::CheckHistory (Packet p, char *file, int line, uint32_t n, ...) +PacketMetadataTest::CheckHistory (Packet p, char *file, int line, uint32_t n, ...) { m_headerError = false; m_trailerError = false; @@ -1335,13 +1335,13 @@ va_start (ap, n); if (m_headerError) { - std::cout << "PacketHistory header error. file=" << file + std::cout << "PacketMetadata header error. file=" << file << ", line=" << line << std::endl; return false; } if (m_trailerError) { - std::cout << "PacketHistory trailer error. file=" << file + std::cout << "PacketMetadata trailer error. file=" << file << ", line=" << line << std::endl; return false; } @@ -1362,7 +1362,7 @@ va_end (ap); return true; error: - std::cout << "PacketHistory error. file="<< file + std::cout << "PacketMetadata error. file="<< file << ", line=" << line << ", got:\""; for (std::list::iterator i = m_prints.begin (); i != m_prints.end (); i++) @@ -1416,11 +1416,11 @@ } bool -PacketHistoryTest::RunTests (void) +PacketMetadataTest::RunTests (void) { bool ok = true; - PacketHistory::Enable (); + PacketMetadata::Enable (); Packet p = Packet (0); Packet p1 = Packet (0); @@ -1626,6 +1626,6 @@ return ok; } -static PacketHistoryTest g_packetHistoryTest; +static PacketMetadataTest g_packetHistoryTest; }//namespace ns3 diff -r 777fcfabc1c8 -r 4d2da35c09b0 src/common/packet-metadata.h --- a/src/common/packet-metadata.h Thu Jun 07 12:48:52 2007 +0200 +++ b/src/common/packet-metadata.h Thu Jun 07 12:51:57 2007 +0200 @@ -18,8 +18,8 @@ * * Author: Mathieu Lacage */ -#ifndef PACKET_HISTORY_H -#define PACKET_HISTORY_H +#ifndef PACKET_METADATA_H +#define PACKET_METADATA_H #include #include @@ -32,15 +32,15 @@ class Chunk; class Buffer; -class PacketHistory { +class PacketMetadata { public: static void Enable (void); static void SetOptOne (bool optOne); - inline PacketHistory (uint32_t uid, uint32_t size); - inline PacketHistory (PacketHistory const &o); - inline PacketHistory &operator = (PacketHistory const& o); - inline ~PacketHistory (); + inline PacketMetadata (uint32_t uid, uint32_t size); + inline PacketMetadata (PacketMetadata const &o); + inline PacketMetadata &operator = (PacketMetadata const& o); + inline ~PacketMetadata (); template void AddHeader (T const &header, uint32_t size); @@ -52,8 +52,8 @@ template void RemoveTrailer (T const &trailer, uint32_t size); - PacketHistory CreateFragment (uint32_t start, uint32_t end) const; - void AddAtEnd (PacketHistory const&o); + PacketMetadata CreateFragment (uint32_t start, uint32_t end) const; + void AddAtEnd (PacketMetadata const&o); void AddPaddingAtEnd (uint32_t end); void RemoveAtStart (uint32_t start); void RemoveAtEnd (uint32_t end); @@ -90,18 +90,18 @@ typedef std::vector DataFreeList; - PacketHistory (); + PacketMetadata (); void DoAddHeader (uint32_t uid, uint32_t size); void DoRemoveHeader (uint32_t uid, uint32_t size); void DoAddTrailer (uint32_t uid, uint32_t size); void DoRemoveTrailer (uint32_t uid, uint32_t size); - inline uint16_t AddSmall (const PacketHistory::SmallItem *item); + inline uint16_t AddSmall (const PacketMetadata::SmallItem *item); uint16_t AddBig (uint32_t head, uint32_t tail, - const PacketHistory::SmallItem *item, - const PacketHistory::ExtraItem *extraItem); - void ReplaceTail (PacketHistory::SmallItem *item, - PacketHistory::ExtraItem *extraItem, + const PacketMetadata::SmallItem *item, + const PacketMetadata::ExtraItem *extraItem); + void ReplaceTail (PacketMetadata::SmallItem *item, + PacketMetadata::ExtraItem *extraItem, uint32_t available); inline void UpdateHead (uint16_t written); inline void UpdateTail (uint16_t written); @@ -116,19 +116,19 @@ void AppendValueExtra (uint32_t value, uint8_t *buffer); inline void Reserve (uint32_t n); void ReserveCopy (uint32_t n); - uint32_t DoPrint (struct PacketHistory::SmallItem *item, uint32_t current, + uint32_t DoPrint (struct PacketMetadata::SmallItem *item, uint32_t current, Buffer data, uint32_t offset, const PacketPrinter &printer, std::ostream &os) const; uint32_t GetTotalSize (void) const; uint32_t ReadItems (uint16_t current, - struct PacketHistory::SmallItem *item, - struct PacketHistory::ExtraItem *extraItem) const; + struct PacketMetadata::SmallItem *item, + struct PacketMetadata::ExtraItem *extraItem) const; - static struct PacketHistory::Data *Create (uint32_t size); - static void Recycle (struct PacketHistory::Data *data); - static struct PacketHistory::Data *Allocate (uint32_t n); - static void Deallocate (struct PacketHistory::Data *data); + static struct PacketMetadata::Data *Create (uint32_t size); + static void Recycle (struct PacketMetadata::Data *data); + static struct PacketMetadata::Data *Allocate (uint32_t n); + static void Deallocate (struct PacketMetadata::Data *data); static DataFreeList m_freeList; static bool m_enable; @@ -148,33 +148,33 @@ template void -PacketHistory::AddHeader (T const &header, uint32_t size) +PacketMetadata::AddHeader (T const &header, uint32_t size) { DoAddHeader (PacketPrinter::GetHeaderUid (), size); } template void -PacketHistory::RemoveHeader (T const &header, uint32_t size) +PacketMetadata::RemoveHeader (T const &header, uint32_t size) { DoRemoveHeader (PacketPrinter::GetHeaderUid (), size); } template void -PacketHistory::AddTrailer (T const &trailer, uint32_t size) +PacketMetadata::AddTrailer (T const &trailer, uint32_t size) { DoAddTrailer (PacketPrinter::GetTrailerUid (), size); } template void -PacketHistory::RemoveTrailer (T const &trailer, uint32_t size) +PacketMetadata::RemoveTrailer (T const &trailer, uint32_t size) { DoRemoveTrailer (PacketPrinter::GetTrailerUid (), size); } -PacketHistory::PacketHistory (uint32_t uid, uint32_t size) - : m_data (m_data = PacketHistory::Create (10)), +PacketMetadata::PacketMetadata (uint32_t uid, uint32_t size) + : m_data (m_data = PacketMetadata::Create (10)), m_head (0xffff), m_tail (0xffff), m_used (0), @@ -186,7 +186,7 @@ DoAddHeader (0, size); } } -PacketHistory::PacketHistory (PacketHistory const &o) +PacketMetadata::PacketMetadata (PacketMetadata const &o) : m_data (o.m_data), m_head (o.m_head), m_tail (o.m_tail), @@ -196,8 +196,8 @@ NS_ASSERT (m_data != 0); m_data->m_count++; } -PacketHistory & -PacketHistory::operator = (PacketHistory const& o) +PacketMetadata & +PacketMetadata::operator = (PacketMetadata const& o) { if (m_data == o.m_data) { @@ -208,7 +208,7 @@ m_data->m_count--; if (m_data->m_count == 0) { - PacketHistory::Recycle (m_data); + PacketMetadata::Recycle (m_data); } m_data = o.m_data; m_head = o.m_head; @@ -219,17 +219,17 @@ m_data->m_count++; return *this; } -PacketHistory::~PacketHistory () +PacketMetadata::~PacketMetadata () { NS_ASSERT (m_data != 0); m_data->m_count--; if (m_data->m_count == 0) { - PacketHistory::Recycle (m_data); + PacketMetadata::Recycle (m_data); } } }; // namespace ns3 -#endif /* PACKET_HISTORY_H */ +#endif /* PACKET_METADATA_H */ diff -r 777fcfabc1c8 -r 4d2da35c09b0 src/common/packet-printer.h --- a/src/common/packet-printer.h Thu Jun 07 12:48:52 2007 +0200 +++ b/src/common/packet-printer.h Thu Jun 07 12:51:57 2007 +0200 @@ -114,8 +114,7 @@ void AddDefaultPrinter (DefaultPrinter printer); private: - friend class PacketHistory; - friend class ::ItemList; + friend class PacketMetadata; typedef void (*DoPrintCallback) (Ptr, Buffer::Iterator, std::ostream &, uint32_t, uint32_t); typedef std::string (*DoGetNameCallback) (void); diff -r 777fcfabc1c8 -r 4d2da35c09b0 src/common/packet.cc --- a/src/common/packet.cc Thu Jun 07 12:48:52 2007 +0200 +++ b/src/common/packet.cc Thu Jun 07 12:51:57 2007 +0200 @@ -52,7 +52,7 @@ i.Write (buffer, size); } -Packet::Packet (Buffer buffer, Tags tags, PacketHistory history, uint32_t uid) +Packet::Packet (Buffer buffer, Tags tags, PacketMetadata history, uint32_t uid) : m_buffer (buffer), m_tags (tags), m_history (history), @@ -65,7 +65,7 @@ Buffer buffer = m_buffer.CreateFragment (start, length); NS_ASSERT (m_buffer.GetSize () >= start + length); uint32_t end = m_buffer.GetSize () - (start + length); - PacketHistory history = m_history.CreateFragment (start, end); + PacketMetadata history = m_history.CreateFragment (start, end); return Packet (buffer, m_tags, history, m_uid); } @@ -144,7 +144,7 @@ void Packet::EnableMetadata (void) { - PacketHistory::Enable (); + PacketMetadata::Enable (); } }; // namespace ns3 diff -r 777fcfabc1c8 -r 4d2da35c09b0 src/common/packet.h --- a/src/common/packet.h Thu Jun 07 12:48:52 2007 +0200 +++ b/src/common/packet.h Thu Jun 07 12:51:57 2007 +0200 @@ -295,10 +295,10 @@ */ static void EnableMetadata (void); private: - Packet (Buffer buffer, Tags tags, PacketHistory history, uint32_t uid); + Packet (Buffer buffer, Tags tags, PacketMetadata history, uint32_t uid); Buffer m_buffer; Tags m_tags; - PacketHistory m_history; + PacketMetadata m_history; uint32_t m_uid; static uint32_t m_globalUid; }; diff -r 777fcfabc1c8 -r 4d2da35c09b0 utils/bench-packets.cc --- a/utils/bench-packets.cc Thu Jun 07 12:48:52 2007 +0200 +++ b/utils/bench-packets.cc Thu Jun 07 12:51:57 2007 +0200 @@ -188,11 +188,11 @@ } - PacketHistory::SetOptOne (false); + PacketMetadata::SetOptOne (false); runBench (&benchPtrA, n, "a"); runBench (&benchPtrB, n, "b"); runBench (&benchPtrC, n, "c"); - PacketHistory::SetOptOne (true); + PacketMetadata::SetOptOne (true); runBench (&benchPtrA, n, "a-opt"); runBench (&benchPtrB, n, "b-opt"); runBench (&benchPtrC, n, "c-opt");