# HG changeset patch # User Mathieu Lacage # Date 1188304433 -7200 # Node ID 12f30b7defb4614ba9efce1f05db6c8c579c5f25 # Parent 61584c0c60f6b7522972a341cf62cf169ad76920 constify diff -r 61584c0c60f6 -r 12f30b7defb4 src/core/composite-trace-resolver.cc --- a/src/core/composite-trace-resolver.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/core/composite-trace-resolver.cc Tue Aug 28 14:33:53 2007 +0200 @@ -74,7 +74,7 @@ void CompositeTraceResolver::AddSource (std::string name, const TraceDoc &doc, - TraceSource &trace) + const TraceSource &trace) { DoAddSource (name, doc, trace, TraceContext ()); } @@ -82,7 +82,7 @@ void CompositeTraceResolver::DoAddSource (std::string name, const TraceDoc &doc, - TraceSource &trace, + const TraceSource &trace, const TraceContext &context) { class SourceCompositeItem : public CompositeItem @@ -106,7 +106,7 @@ } *item = new SourceCompositeItem (); item->name = name; item->context = context; - item->trace = &trace; + item->trace = const_cast (&trace); item->doc = doc; AddItem (item); } diff -r 61584c0c60f6 -r 12f30b7defb4 src/core/composite-trace-resolver.h --- a/src/core/composite-trace-resolver.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/core/composite-trace-resolver.h Tue Aug 28 14:33:53 2007 +0200 @@ -55,7 +55,7 @@ */ template void AddSource (std::string name, const TraceDoc &doc, - TraceSource &trace, T const &context); + const TraceSource &trace, T const &context); /** * \param name name of trace source * \param trace a callback trace source @@ -66,7 +66,7 @@ */ void AddSource (std::string name, const TraceDoc &doc, - TraceSource &trace); + const TraceSource &trace); void AddChild (std::string name, Ptr child); @@ -116,7 +116,7 @@ void DoAddChild (std::string name, Ptr child, const TraceContext &context); void DoAddSource (std::string name, const TraceDoc &doc, - TraceSource &trace, + const TraceSource &trace, const TraceContext &context); void Add (std::string name, Callback > createResolver); @@ -136,7 +136,7 @@ void CompositeTraceResolver::AddSource (std::string name, const TraceDoc &doc, - TraceSource &trace, + const TraceSource &trace, T const &context) { TraceContext ctx; diff -r 61584c0c60f6 -r 12f30b7defb4 src/core/object.cc --- a/src/core/object.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/core/object.cc Tue Aug 28 14:33:53 2007 +0200 @@ -63,20 +63,20 @@ class InterfaceIdTraceResolver : public TraceResolver { public: - InterfaceIdTraceResolver (Ptr aggregate); + InterfaceIdTraceResolver (Ptr aggregate); virtual void Connect (std::string path, CallbackBase const &cb, const TraceContext &context); virtual void Disconnect (std::string path, CallbackBase const &cb); virtual void CollectSources (std::string path, const TraceContext &context, SourceCollection *collection); private: - Ptr ParseForInterface (std::string path); - Ptr m_aggregate; + Ptr ParseForInterface (std::string path); + Ptr m_aggregate; }; -InterfaceIdTraceResolver::InterfaceIdTraceResolver (Ptr aggregate) +InterfaceIdTraceResolver::InterfaceIdTraceResolver (Ptr aggregate) : m_aggregate (aggregate) {} -Ptr +Ptr InterfaceIdTraceResolver::ParseForInterface (std::string path) { std::string element = GetElement (path); @@ -93,7 +93,7 @@ void InterfaceIdTraceResolver::Connect (std::string path, CallbackBase const &cb, const TraceContext &context) { - Ptr interface = ParseForInterface (path); + Ptr interface = ParseForInterface (path); if (interface != 0) { interface->GetTraceResolver ()->Connect (GetSubpath (path), cb, context); @@ -102,7 +102,7 @@ void InterfaceIdTraceResolver::Disconnect (std::string path, CallbackBase const &cb) { - Ptr interface = ParseForInterface (path); + Ptr interface = ParseForInterface (path); if (interface != 0) { interface->TraceDisconnect (GetSubpath (path), cb); @@ -232,12 +232,12 @@ } void -Object::TraceConnect (std::string path, const CallbackBase &cb) +Object::TraceConnect (std::string path, const CallbackBase &cb) const { GetTraceResolver ()->Connect (path, cb, TraceContext ()); } void -Object::TraceDisconnect (std::string path, const CallbackBase &cb) +Object::TraceDisconnect (std::string path, const CallbackBase &cb) const { GetTraceResolver ()->Disconnect (path, cb); } @@ -256,7 +256,7 @@ } Ptr -Object::GetTraceResolver (void) +Object::GetTraceResolver (void) const { Ptr resolver = Create (this); @@ -298,9 +298,9 @@ void Object::DoCollectSources (std::string path, const TraceContext &context, - TraceResolver::SourceCollection *collection) + TraceResolver::SourceCollection *collection) const { - Object *current; + const Object *current; current = this; do { if (current->m_collecting) diff -r 61584c0c60f6 -r 12f30b7defb4 src/core/object.h --- a/src/core/object.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/core/object.h Tue Aug 28 14:33:53 2007 +0200 @@ -149,7 +149,7 @@ * match the input path. * */ - void TraceConnect (std::string path, const CallbackBase &cb); + void TraceConnect (std::string path, const CallbackBase &cb) const; /** * \param path the path to match for the callback * \param cb callback to disconnect @@ -157,13 +157,13 @@ * Disconnect the input callback from all trace sources which * match the input path. */ - void TraceDisconnect (std::string path, const CallbackBase &cb); + void TraceDisconnect (std::string path, const CallbackBase &cb) const; /** * \returns the trace resolver associated to this object. * * This method should be rarely called by users. */ - virtual Ptr GetTraceResolver (void); + virtual Ptr GetTraceResolver (void) const; protected: /** * \param iid an InterfaceId @@ -183,13 +183,13 @@ friend class InterfaceIdTraceResolver; Ptr DoQueryInterface (InterfaceId iid) const; void DoCollectSources (std::string path, const TraceContext &context, - TraceResolver::SourceCollection *collection); + TraceResolver::SourceCollection *collection) const; bool Check (void) const; void MaybeDelete (void) const; mutable uint32_t m_count; InterfaceId m_iid; bool m_disposed; - bool m_collecting; + mutable bool m_collecting; Object *m_next; }; diff -r 61584c0c60f6 -r 12f30b7defb4 src/devices/csma/csma-net-device.cc --- a/src/devices/csma/csma-net-device.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/devices/csma/csma-net-device.cc Tue Aug 28 14:33:53 2007 +0200 @@ -458,7 +458,7 @@ } Ptr -CsmaNetDevice::GetTraceResolver (void) +CsmaNetDevice::GetTraceResolver (void) const { Ptr resolver = Create (); resolver->AddChild ("queue", m_queue); diff -r 61584c0c60f6 -r 12f30b7defb4 src/devices/csma/csma-net-device.h --- a/src/devices/csma/csma-net-device.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/devices/csma/csma-net-device.h Tue Aug 28 14:33:53 2007 +0200 @@ -212,7 +212,7 @@ * (NOT TESTED) * @see class TraceResolver */ - virtual Ptr GetTraceResolver (void); + virtual Ptr GetTraceResolver (void) const; /** * Get a copy of the attached Queue. diff -r 61584c0c60f6 -r 12f30b7defb4 src/devices/point-to-point/point-to-point-net-device.cc --- a/src/devices/point-to-point/point-to-point-net-device.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/devices/point-to-point/point-to-point-net-device.cc Tue Aug 28 14:33:53 2007 +0200 @@ -195,7 +195,7 @@ } Ptr -PointToPointNetDevice::GetTraceResolver (void) +PointToPointNetDevice::GetTraceResolver (void) const { Ptr resolver = Create (); resolver->AddChild ("queue", m_queue); diff -r 61584c0c60f6 -r 12f30b7defb4 src/devices/point-to-point/point-to-point-net-device.h --- a/src/devices/point-to-point/point-to-point-net-device.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/devices/point-to-point/point-to-point-net-device.h Tue Aug 28 14:33:53 2007 +0200 @@ -158,7 +158,7 @@ * * @see class TraceResolver */ - virtual Ptr GetTraceResolver (void); + virtual Ptr GetTraceResolver (void) const; virtual void DoDispose (void); /** * Get a copy of the attached Queue. diff -r 61584c0c60f6 -r 12f30b7defb4 src/internet-node/arp-ipv4-interface.cc --- a/src/internet-node/arp-ipv4-interface.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/internet-node/arp-ipv4-interface.cc Tue Aug 28 14:33:53 2007 +0200 @@ -41,7 +41,7 @@ {} Ptr -ArpIpv4Interface::GetTraceResolver (void) +ArpIpv4Interface::GetTraceResolver (void) const { Ptr resolver = Create (); if (GetDevice () != 0) diff -r 61584c0c60f6 -r 12f30b7defb4 src/internet-node/arp-ipv4-interface.h --- a/src/internet-node/arp-ipv4-interface.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/internet-node/arp-ipv4-interface.h Tue Aug 28 14:33:53 2007 +0200 @@ -43,7 +43,7 @@ virtual ~ArpIpv4Interface (); protected: - virtual Ptr GetTraceResolver (void); + virtual Ptr GetTraceResolver (void) const; private: virtual void SendTo (Packet p, Ipv4Address dest); Ptr m_node; diff -r 61584c0c60f6 -r 12f30b7defb4 src/internet-node/internet-node.cc --- a/src/internet-node/internet-node.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/internet-node/internet-node.cc Tue Aug 28 14:33:53 2007 +0200 @@ -75,7 +75,7 @@ } Ptr -InternetNode::GetTraceResolver () +InternetNode::GetTraceResolver () const { Ptr resolver = Create (); Ptr ipv4 = QueryInterface (Ipv4L3Protocol::iid); diff -r 61584c0c60f6 -r 12f30b7defb4 src/internet-node/internet-node.h --- a/src/internet-node/internet-node.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/internet-node/internet-node.h Tue Aug 28 14:33:53 2007 +0200 @@ -42,7 +42,7 @@ protected: virtual void DoDispose(void); - virtual Ptr GetTraceResolver (void); + virtual Ptr GetTraceResolver (void) const; private: bool ReceiveFromDevice (Ptr device, const Packet &p, uint16_t protocolNumber) const; void Construct (void); diff -r 61584c0c60f6 -r 12f30b7defb4 src/internet-node/ipv4-l3-protocol.cc --- a/src/internet-node/ipv4-l3-protocol.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/internet-node/ipv4-l3-protocol.cc Tue Aug 28 14:33:53 2007 +0200 @@ -159,7 +159,7 @@ } Ptr -Ipv4L3Protocol::GetTraceResolver (void) +Ipv4L3Protocol::GetTraceResolver (void) const { Ptr resolver = Create (); resolver->AddSource ("tx", diff -r 61584c0c60f6 -r 12f30b7defb4 src/internet-node/ipv4-l3-protocol.h --- a/src/internet-node/ipv4-l3-protocol.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/internet-node/ipv4-l3-protocol.h Tue Aug 28 14:33:53 2007 +0200 @@ -171,7 +171,7 @@ protected: virtual void DoDispose (void); - virtual Ptr GetTraceResolver (void); + virtual Ptr GetTraceResolver (void) const; private: diff -r 61584c0c60f6 -r 12f30b7defb4 src/internet-node/ipv4-l4-demux.cc --- a/src/internet-node/ipv4-l4-demux.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/internet-node/ipv4-l4-demux.cc Tue Aug 28 14:33:53 2007 +0200 @@ -84,7 +84,7 @@ } Ptr -Ipv4L4Demux::GetTraceResolver (void) +Ipv4L4Demux::GetTraceResolver (void) const { Ptr resolver = Create (); for (L4List_t::const_iterator i = m_protocols.begin(); i != m_protocols.end(); ++i) diff -r 61584c0c60f6 -r 12f30b7defb4 src/internet-node/ipv4-l4-demux.h --- a/src/internet-node/ipv4-l4-demux.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/internet-node/ipv4-l4-demux.h Tue Aug 28 14:33:53 2007 +0200 @@ -89,7 +89,7 @@ */ void Remove (Ptr protocol); protected: - Ptr GetTraceResolver (void); + Ptr GetTraceResolver (void) const; virtual void DoDispose (void); private: typedef std::list > L4List_t; diff -r 61584c0c60f6 -r 12f30b7defb4 src/mobility/mobility-model-notifier.cc --- a/src/mobility/mobility-model-notifier.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/mobility/mobility-model-notifier.cc Tue Aug 28 14:33:53 2007 +0200 @@ -41,7 +41,7 @@ } Ptr -MobilityModelNotifier::GetTraceResolver (void) +MobilityModelNotifier::GetTraceResolver (void) const { Ptr resolver = Create (); diff -r 61584c0c60f6 -r 12f30b7defb4 src/mobility/mobility-model-notifier.h --- a/src/mobility/mobility-model-notifier.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/mobility/mobility-model-notifier.h Tue Aug 28 14:33:53 2007 +0200 @@ -48,7 +48,7 @@ */ void Notify (Ptr position) const; protected: - virtual Ptr GetTraceResolver (void); + virtual Ptr GetTraceResolver (void) const; private: CallbackTraceSource > m_trace; }; diff -r 61584c0c60f6 -r 12f30b7defb4 src/node/node-list.cc --- a/src/node/node-list.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/node/node-list.cc Tue Aug 28 14:33:53 2007 +0200 @@ -67,9 +67,9 @@ ~NodeListPriv (); uint32_t Add (Ptr node); - NodeList::Iterator Begin (void); - NodeList::Iterator End (void); - Ptr GetTraceResolver (void); + NodeList::Iterator Begin (void) const; + NodeList::Iterator End (void) const; + Ptr GetTraceResolver (void) const; Ptr GetNode (uint32_t n); uint32_t GetNNodes (void); @@ -101,12 +101,12 @@ } NodeList::Iterator -NodeListPriv::Begin (void) +NodeListPriv::Begin (void) const { return m_nodes.begin (); } NodeList::Iterator -NodeListPriv::End (void) +NodeListPriv::End (void) const { return m_nodes.end (); } @@ -124,7 +124,7 @@ Ptr -NodeListPriv::GetTraceResolver (void) +NodeListPriv::GetTraceResolver (void) const { Ptr resolver = Create (); resolver->AddArray ("nodes", Begin (), End (), NodeListIndex ()); diff -r 61584c0c60f6 -r 12f30b7defb4 src/node/node-list.h --- a/src/node/node-list.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/node/node-list.h Tue Aug 28 14:33:53 2007 +0200 @@ -54,7 +54,7 @@ class NodeList { public: - typedef std::vector< Ptr >::iterator Iterator; + typedef std::vector< Ptr >::const_iterator Iterator; /** * \param node node to add diff -r 61584c0c60f6 -r 12f30b7defb4 src/node/node.cc --- a/src/node/node.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/node/node.cc Tue Aug 28 14:33:53 2007 +0200 @@ -87,7 +87,7 @@ {} Ptr -Node::GetTraceResolver (void) +Node::GetTraceResolver (void) const { Ptr resolver = Create (); resolver->AddArray ("devices", m_devices.begin (), m_devices.end (), NodeNetDeviceIndex ()); diff -r 61584c0c60f6 -r 12f30b7defb4 src/node/node.h --- a/src/node/node.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/node/node.h Tue Aug 28 14:33:53 2007 +0200 @@ -173,7 +173,7 @@ void UnregisterProtocolHandler (ProtocolHandler handler); protected: - virtual Ptr GetTraceResolver (void); + virtual Ptr GetTraceResolver (void) const; /** * The dispose method. Subclasses must override this method * and must chain up to it by calling Node::DoDispose at the diff -r 61584c0c60f6 -r 12f30b7defb4 src/node/queue.cc --- a/src/node/queue.cc Tue Aug 28 14:32:44 2007 +0200 +++ b/src/node/queue.cc Tue Aug 28 14:33:53 2007 +0200 @@ -100,7 +100,7 @@ } Ptr -Queue::GetTraceResolver (void) +Queue::GetTraceResolver (void) const { Ptr resolver = Create (); resolver->AddSource ("enqueue", diff -r 61584c0c60f6 -r 12f30b7defb4 src/node/queue.h --- a/src/node/queue.h Tue Aug 28 14:32:44 2007 +0200 +++ b/src/node/queue.h Tue Aug 28 14:33:53 2007 +0200 @@ -166,7 +166,7 @@ virtual bool DoPeek (Packet &p) = 0; protected: - Ptr GetTraceResolver (void); + Ptr GetTraceResolver (void) const; // called by subclasses to notify parent of packet drops. void Drop (const Packet& p);