Backed out changeset ae9f7d5e2d56
authorGustavo J. A. M. Carneiro <gjc@inescporto.pt>
Mon, 07 Jul 2008 10:26:00 +0100
changeset 3446 8491c6c05d22
parent 3445 ae9f7d5e2d56
child 3447 48f371a8ae8e
Backed out changeset ae9f7d5e2d56
src/devices/csma/csma-net-device.cc
src/devices/csma/csma-net-device.h
src/node/net-device.cc
src/node/net-device.h
src/node/node.cc
--- a/src/devices/csma/csma-net-device.cc	Fri Jul 04 19:15:00 2008 +0100
+++ b/src/devices/csma/csma-net-device.cc	Mon Jul 07 10:26:00 2008 +0100
@@ -833,10 +833,4 @@
   m_promiscRxCallback = cb;
 }
 
-bool
-CsmaNetDevice::SupportsPromiscuousReceiveCallback (void) const
-{
-  return true;
-}
-
 } // namespace ns3
--- a/src/devices/csma/csma-net-device.h	Fri Jul 04 19:15:00 2008 +0100
+++ b/src/devices/csma/csma-net-device.h	Mon Jul 07 10:26:00 2008 +0100
@@ -286,7 +286,6 @@
    */
   virtual void SetReceiveCallback (NetDevice::ReceiveCallback cb);
   virtual void SetPromiscuousReceiveCallback (PromiscuousReceiveCallback cb);
-  virtual bool SupportsPromiscuousReceiveCallback (void) const;
 
 protected:
   /**
--- a/src/node/net-device.cc	Fri Jul 04 19:15:00 2008 +0100
+++ b/src/node/net-device.cc	Mon Jul 07 10:26:00 2008 +0100
@@ -21,7 +21,6 @@
 #include "ns3/object.h"
 #include "ns3/log.h"
 #include "net-device.h"
-#include "ns3/packet.h"
 
 NS_LOG_COMPONENT_DEFINE ("NetDevice");
 
@@ -39,24 +38,4 @@
 NetDevice::~NetDevice ()
 {}
 
-bool
-NetDevice::SupportsPromiscuousReceiveCallback (void) const
-{
-  return false;
-}
-
-void
-NetDevice::SetPromiscuousReceiveCallback (PromiscuousReceiveCallback cb)
-{
-  NS_FATAL_ERROR ("promiscuous receive callback not supported for this device");
-}
-
-bool
-NetDevice::SendFrom(Ptr<Packet> packet, const Address& source, const Address& dest, uint16_t protocolNumber)
-{
-  NS_FATAL_ERROR ("NetDevice " << GetInstanceTypeId ().GetName () << " does not support SendFrom.");
-  return false;
-}
-
-
 } // namespace ns3
--- a/src/node/net-device.h	Fri Jul 04 19:15:00 2008 +0100
+++ b/src/node/net-device.h	Mon Jul 07 10:26:00 2008 +0100
@@ -228,7 +228,7 @@
    * 
    * \return whether the Send operation succeeded 
    */
-  virtual bool SendFrom(Ptr<Packet> packet, const Address& source, const Address& dest, uint16_t protocolNumber);
+  virtual bool SendFrom(Ptr<Packet> packet, const Address& source, const Address& dest, uint16_t protocolNumber) = 0;
   /**
    * \returns the node base class which contains this network
    *          interface.
@@ -297,12 +297,7 @@
    *        it.  In that sense, it receives a superset of packets
    *        received by the normal ReceivedCallback.
    */
-  virtual void SetPromiscuousReceiveCallback (PromiscuousReceiveCallback cb);
-
-  /**
-   * \returns true if device supports promiscuous receive callback
-   */
-  virtual bool SupportsPromiscuousReceiveCallback (void) const;
+  virtual void SetPromiscuousReceiveCallback (PromiscuousReceiveCallback cb) = 0;
 
 };
 
--- a/src/node/node.cc	Fri Jul 04 19:15:00 2008 +0100
+++ b/src/node/node.cc	Mon Jul 07 10:26:00 2008 +0100
@@ -96,10 +96,7 @@
   device->SetNode (this);
   device->SetIfIndex(index);
   device->SetReceiveCallback (MakeCallback (&Node::ReceiveFromDevice, this));
-  if (device->SupportsPromiscuousReceiveCallback ())
-    {
-      device->SetPromiscuousReceiveCallback (MakeCallback (&Node::PromiscuousReceiveFromDevice, this));
-    }
+  device->SetPromiscuousReceiveCallback (MakeCallback (&Node::PromiscuousReceiveFromDevice, this));
   NotifyDeviceAdded (device);
   return index;
 }
@@ -194,10 +191,6 @@
   entry.handler = handler;
   entry.protocol = protocolType;
   entry.device = device;
-  if (device)
-    {
-      NS_ASSERT (device->SupportsPromiscuousReceiveCallback ());
-    }
   m_promiscuousHandlers.push_back (entry);
 }