bug 2158: Fix flooding of packets on input port, for packets received on in!=0
When you have the action OFPP_FLOOD on a flow, and the received packet is
not coming into the switch through port 0, then the packet will be flooded on
all ports, including the receiving port! This is especially bad if
you have broadcasts as packets will get replicated indefinitely (ARP req for
e.g.). This is caused by missing ntohs() that fails to convert port numbers
to their correct values. The switch works correctly for broadcast packets
received on port zero.
Example: The ReceivePacketOut() gets 0 if the input port is 0 and it works.
But will get 512 if the input port is 1 and since 512 is not our real input
port the check will fail and the packet will also be replicated on the input
port.
--- a/src/openflow/model/openflow-switch-net-device.cc Thu Aug 27 18:08:12 2015 -0700
+++ b/src/openflow/model/openflow-switch-net-device.cc Mon Aug 31 10:41:05 2015 -0700
@@ -1144,7 +1144,7 @@
}
sw_flow_key key;
- flow_extract (buffer, opo->in_port, &key.flow); // ntohs(opo->in_port)
+ flow_extract (buffer, ntohs(opo->in_port), &key.flow); // ntohs(opo->in_port)
uint16_t v_code = ofi::ValidateActions (&key, opo->actions, actions_len);
if (v_code != ACT_VALIDATION_OK)
@@ -1287,7 +1287,7 @@
{
sw_flow_key key;
flow_used (flow, buffer);
- flow_extract (buffer, ofm->match.in_port, &key.flow); // ntohs(ofm->match.in_port);
+ flow_extract (buffer, ntohs(ofm->match.in_port), &key.flow); // ntohs(ofm->match.in_port);
ofi::ExecuteActions (this, ofm->buffer_id, buffer, &key, ofm->actions, actions_len, false);
ofpbuf_delete (buffer);
}
@@ -1328,7 +1328,7 @@
if (buffer)
{
sw_flow_key skb_key;
- flow_extract (buffer, ofm->match.in_port, &skb_key.flow); // ntohs(ofm->match.in_port);
+ flow_extract (buffer, ntohs(ofm->match.in_port), &skb_key.flow); // ntohs(ofm->match.in_port);
ofi::ExecuteActions (this, ofm->buffer_id, buffer, &skb_key, ofm->actions, actions_len, false);
ofpbuf_delete (buffer);
}