gcc 3.4 complained about virtual methods without virtual destructor
authorCraig Dowell <craigdo@ee.washington.edu>
Sun Sep 13 15:35:33 2009 -0700 (4 months ago)
changeset 479095015b7f0269
parent 4789 a37dd7f8de25
child 4791 f38ed76fae2b
gcc 3.4 complained about virtual methods without virtual destructor
src/node/packetbb.cc
src/node/packetbb.h
     1.1 --- a/src/node/packetbb.cc	Sun Sep 13 09:38:01 2009 -0700
     1.2 +++ b/src/node/packetbb.cc	Sun Sep 13 15:35:33 2009 -0700
     1.3 @@ -908,7 +908,7 @@
     1.4  
     1.5  /* End PbbPacket class */
     1.6  
     1.7 -PbbMessage::PbbMessage (void)
     1.8 +PbbMessage::PbbMessage ()
     1.9  {
    1.10    m_refCount = 1;
    1.11    /* Default to IPv4 */
    1.12 @@ -919,6 +919,10 @@
    1.13    m_hasSequenceNumber = false;
    1.14  }
    1.15  
    1.16 +PbbMessage::~PbbMessage ()
    1.17 +{
    1.18 +}
    1.19 +
    1.20  void
    1.21  PbbMessage::SetType (uint8_t type)
    1.22  {
    1.23 @@ -1558,6 +1562,14 @@
    1.24  
    1.25  /* End PbbMessage Class */
    1.26  
    1.27 +PbbMessageIpv4::PbbMessageIpv4 ()
    1.28 +{
    1.29 +}
    1.30 +
    1.31 +PbbMessageIpv4::~PbbMessageIpv4 ()
    1.32 +{
    1.33 +}
    1.34 +
    1.35  PbbAddressLength
    1.36  PbbMessageIpv4::GetAddressLength (void) const
    1.37  {
    1.38 @@ -1596,6 +1608,14 @@
    1.39  
    1.40  /* End PbbMessageIpv4 Class */
    1.41  
    1.42 +PbbMessageIpv6::PbbMessageIpv6 ()
    1.43 +{
    1.44 +}
    1.45 +
    1.46 +PbbMessageIpv6::~PbbMessageIpv6 ()
    1.47 +{
    1.48 +}
    1.49 +
    1.50  PbbAddressLength
    1.51  PbbMessageIpv6::GetAddressLength (void) const
    1.52  {
    1.53 @@ -1639,6 +1659,10 @@
    1.54    m_refCount = 1;
    1.55  }
    1.56  
    1.57 +PbbAddressBlock::~PbbAddressBlock ()
    1.58 +{
    1.59 +}
    1.60 +
    1.61  /* Manipulating the address block */
    1.62  
    1.63  PbbAddressBlock::AddressIterator
    1.64 @@ -2307,6 +2331,14 @@
    1.65  
    1.66  /* End PbbAddressBlock Class */
    1.67  
    1.68 +PbbAddressBlockIpv4::PbbAddressBlockIpv4 ()
    1.69 +{
    1.70 +}
    1.71 +
    1.72 +PbbAddressBlockIpv4::~PbbAddressBlockIpv4 ()
    1.73 +{
    1.74 +}
    1.75 +
    1.76  uint8_t
    1.77  PbbAddressBlockIpv4::GetAddressLength (void) const
    1.78  {
    1.79 @@ -2333,6 +2365,14 @@
    1.80  
    1.81  /* End PbbAddressBlockIpv4 Class */
    1.82  
    1.83 +PbbAddressBlockIpv6::PbbAddressBlockIpv6 ()
    1.84 +{
    1.85 +}
    1.86 +
    1.87 +PbbAddressBlockIpv6::~PbbAddressBlockIpv6 ()
    1.88 +{
    1.89 +}
    1.90 +
    1.91  uint8_t
    1.92  PbbAddressBlockIpv6::GetAddressLength (void) const
    1.93  {
     2.1 --- a/src/node/packetbb.h	Sun Sep 13 09:38:01 2009 -0700
     2.2 +++ b/src/node/packetbb.h	Sun Sep 13 15:35:33 2009 -0700
     2.3 @@ -655,7 +655,8 @@
     2.4    typedef std::list< Ptr<PbbAddressBlock> >::iterator AddressBlockIterator;
     2.5    typedef std::list< Ptr<PbbAddressBlock> >::const_iterator ConstAddressBlockIterator;
     2.6  
     2.7 -  PbbMessage (void);
     2.8 +  PbbMessage ();
     2.9 +  virtual ~PbbMessage ();
    2.10  
    2.11    /**
    2.12     * \brief Sets the type for this message.
    2.13 @@ -1049,6 +1050,10 @@
    2.14   * This message will only contain IPv4 addresses.
    2.15   */
    2.16  class PbbMessageIpv4 : public PbbMessage {
    2.17 +public:
    2.18 +  PbbMessageIpv4 ();
    2.19 +  virtual ~PbbMessageIpv4 ();
    2.20 +
    2.21  protected:
    2.22    virtual PbbAddressLength GetAddressLength (void) const;
    2.23  
    2.24 @@ -1065,6 +1070,10 @@
    2.25   * This message will only contain IPv6 addresses.
    2.26   */
    2.27  class PbbMessageIpv6 : public PbbMessage {
    2.28 +public:
    2.29 +  PbbMessageIpv6 ();
    2.30 +  virtual ~PbbMessageIpv6 ();
    2.31 +
    2.32  protected:
    2.33    virtual PbbAddressLength GetAddressLength (void) const;
    2.34  
    2.35 @@ -1093,7 +1102,8 @@
    2.36    typedef PbbAddressTlvBlock::Iterator TlvIterator;
    2.37    typedef PbbAddressTlvBlock::ConstIterator ConstTlvIterator;
    2.38  
    2.39 -  PbbAddressBlock (void);
    2.40 +  PbbAddressBlock ();
    2.41 +  virtual ~PbbAddressBlock ();
    2.42  
    2.43    /* Manipulating the address block */
    2.44  
    2.45 @@ -1468,6 +1478,10 @@
    2.46   */
    2.47  class PbbAddressBlockIpv4 : public PbbAddressBlock
    2.48  {
    2.49 +public:
    2.50 +  PbbAddressBlockIpv4 ();
    2.51 +  virtual ~PbbAddressBlockIpv4 ();
    2.52 +
    2.53  protected:
    2.54    virtual uint8_t GetAddressLength (void) const;
    2.55  
    2.56 @@ -1483,6 +1497,10 @@
    2.57   */
    2.58  class PbbAddressBlockIpv6 : public PbbAddressBlock
    2.59  {
    2.60 +public:
    2.61 +  PbbAddressBlockIpv6 ();
    2.62 +  virtual ~PbbAddressBlockIpv6 ();
    2.63 +
    2.64  protected:
    2.65    virtual uint8_t GetAddressLength (void) const;
    2.66